Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #554

Merged
merged 11 commits into from
Jun 4, 2023
Merged

chore: sync upstream #554

merged 11 commits into from
Jun 4, 2023

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Bug Fixes

Documentation

Code Refactoring

satoshi-ota and others added 11 commits June 2, 2023 14:13
* refactor(avoidance): create helper class

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(avoidance): clean up header file

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…utowarefoundation#3874)

* feat: add parameter for holding last detected traffic-signal color

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix: apply pre-commit

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
)

* fix(motion_utils): check if the buffer is empty

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add test to check if the old data is discarded

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…ndation#3885)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…undation#3780)

* Implementer the traffic signal arbiter

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Fixed the same of the launcher

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Deleted unused package

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Fixed a name and replaced v2x mentions to external to make it more general

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Fixed topic types typo in the docs

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Changed the header file to the standard path

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Fixed the documentation to reflect the requested name changes (v2x -> external)

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
…f merge_from_private_road (autowarefoundation#3891)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…ation#3287)

* fix(smoke_test): fix smoke test failing with big nodes

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

* style(pre-commit): autofix

* minor style changes and comment removal

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

* moved params to right files

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

* added smoke test support for multiple tests with different params

added general support for multiple smoke tests for one node with different params and added tests for trajectory_follower_node with different controllers

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

* style(pre-commit): autofix

* Parameters structure copied from autoware launch

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

* Fixed GTests and Readme

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>

---------

Signed-off-by: Mateusz Palczuk <mateusz.palczuk@robotec.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…3803)

* consolidate planWithPriority function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add comments

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* refactoring

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* refactoring

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change arg type

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/scene_module/pull_out/pull_out_module.cpp

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/pull_out/pull_out_module.hpp

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
…tion#3889)

Slight typo correction in Obstacle Cruise Planner doc.

Signed-off-by: Takumi Ito <takumi.ito@tier4.jp>
Co-authored-by: Takumi Ito <takumi.ito@tier4.jp>
* fix(goal_planner): fix goal planner execution

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Patch coverage: 10.26% and project coverage change: +5.30 🎉

Comparison is base (029dbd1) 12.94% compared to head (4eef087) 18.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##           tier4/main     #554      +/-   ##
==============================================
+ Coverage       12.94%   18.24%   +5.30%     
==============================================
  Files             380      443      +63     
  Lines           35982    46809   +10827     
  Branches        13228    20716    +7488     
==============================================
+ Hits             4659     8542    +3883     
- Misses          26249    27147     +898     
- Partials         5074    11120    +6046     
Flag Coverage Δ
differential 18.24% <10.26%> (+5.30%) ⬆️
Impacted Files Coverage Δ
...ectory_follower_node/test/test_controller_node.cpp 24.45% <ø> (ø)
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% <0.00%> (ø)
...raffic_light_arbiter/src/traffic_light_arbiter.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
..._planner/scene_module/pull_out/pull_out_module.hpp 50.00% <ø> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 5.80% <0.00%> (+0.12%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.59% <0.00%> (+0.11%) ⬆️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.97% <2.04%> (-0.01%) ⬇️
...e/behavior_path_planner/utils/avoidance/helper.hpp 11.42% <11.42%> (ø)
... and 4 more

... and 218 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 107f115 into tier4/main Jun 4, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch June 4, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common control documentation Improvements or additions to documentation perception planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.