Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_planning_rviz_plugin): fix build error in Humble #450

Merged
merged 2 commits into from
May 15, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 15, 2023

Description

以下を修正

tf2_geometry_msgs.h -> tf2_geometry_msgs.hpp

Related Links

https://tier4.atlassian.net/browse/AEAP-488

Tests performed

tier4_planning_rviz_pluginがビルドできること

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.16@6b341aa). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #450   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?      14           
  Lines                   ?    1288           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?    1288           
  Partials                ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@m-iwashita-esol m-iwashita-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/tier4_planning_rviz_plugin以下全てのtf2_geometry_msgs/tf2_geometry_msgs.h -> hpp置き換えを確認しました

@h-ohta h-ohta merged commit 36358a2 into beta/v0.3.16 May 15, 2023
@h-ohta h-ohta deleted the fix/tier4_planning_rviz branch May 15, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants