Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): fix build error in Humble #441

Merged
merged 3 commits into from
May 12, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 12, 2023

Description

Humbleでのビルドエラーを修正

  • boost::shared_ptr -> pcl::shared_ptr
  • tf2_geometry_msgs.h -> tf2_geometry_msgs.hpp
  • tf2_eigen.h -> tf2_eigen.hpp

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

依存モジュールに引っかかり、pointcloud_preprocessorのビルドに到達しませんでした。
以下時点のbeta/v0.3.16にリベースすることでBoost関連のWarningこそ表示されますが、ビルドOKとなります。

fix(tier4_pcl_extensions): modify build error in humble (#439)
b870dd1

Starting >>> pointcloud_preprocessor
[Processing: pointcloud_preprocessor]
--- stderr: pointcloud_preprocessor
** WARNING ** io features related to pcap will be disabled
In file included from /usr/include/boost/math/tools/cxx03_warn.hpp:9,
                 from /usr/include/boost/math/constants/constants.hpp:11,
                 from /usr/include/boost/geometry/util/math.hpp:29,
                 from /usr/include/boost/geometry/util/is_inverse_spheroidal_coordinates.hpp:19,
                 from /usr/include/boost/geometry/algorithms/detail/assign_values.hpp:42,
                 from /usr/include/boost/geometry/algorithms/detail/assign_box_corners.hpp:21,
                 from /usr/include/boost/geometry/algorithms/convert.hpp:38,
                 from /usr/include/boost/geometry/geometries/box.hpp:22,
                 from /usr/include/boost/geometry/geometries/geometries.hpp:25,
                 from /home/se-osaka-dev34/autoware/install/tier4_autoware_utils/include/tier4_autoware_utils/geometry/boost_geometry.hpp:19,
                 from /home/se-osaka-dev34/autoware/src/autoware/universe/sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/vector_map_filter/lanelet2_map_filter_nodelet.hpp:22,
                 from /home/se-osaka-dev34/autoware/src/autoware/universe/sensing/pointcloud_preprocessor/src/vector_map_filter/lanelet2_map_filter_nodelet.cpp:15:
/usr/include/boost/detail/no_exceptions_support.hpp:17:1: note: ‘#pragma message: This header is deprecated. Use <boost/core/no_exceptions_support.hpp> instead.’
   17 | BOOST_HEADER_DEPRECATED("<boost/core/no_exceptions_support.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
---
Finished <<< pointcloud_preprocessor [42.0s]

@h-ohta
Copy link
Author

h-ohta commented May 12, 2023

最新にするのを忘れてました

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM。

ビルドOKです。

@h-ohta h-ohta merged commit 2502fef into beta/v0.3.16 May 12, 2023
@h-ohta h-ohta deleted the fix/poitcloud_preprocessor branch May 12, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants