Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update aggregator #363

Merged
merged 4 commits into from
Apr 17, 2023
Merged

chore: update aggregator #363

merged 4 commits into from
Apr 17, 2023

Conversation

0x126
Copy link

@0x126 0x126 commented Apr 15, 2023

Description

  • Update aggregator settings

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@0x126 0x126 requested review from TomohitoAndo, asana17, Yukio247 and ito-san and removed request for ito-san April 15, 2023 12:36
@0x126 0x126 marked this pull request as ready for review April 15, 2023 12:37
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@73f0d06). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.6.1     #363   +/-   ##
==============================================
  Coverage               ?   10.59%           
==============================================
  Files                  ?     1247           
  Lines                  ?    89990           
  Branches               ?    20801           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70371           
  Partials               ?    10087           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (?) Carriedforward from b7d18ed

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@asana17 asana17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0x126 0x126 merged commit 17493a5 into beta/v0.6.1 Apr 17, 2023
@0x126 0x126 deleted the chore/update-aggregator branch April 17, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants