Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #355

Merged
merged 21 commits into from
Apr 11, 2023
Merged

chore: sync upstream #355

merged 21 commits into from
Apr 11, 2023

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Bug Fixes

Code Refactoring

Chores

purewater0901 and others added 21 commits April 10, 2023 09:57
)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kosuke55 <kosuke55@users.noreply.github.com>
…dation#3191)

* Add OutOfLane module to the behavior_velocity_planner

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add functions for calculating path footprint and overlaps (WIP)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Update behavior_planning launch file to add out_of_lane param file

TODO: remove launch-prefix from this commit. only needed for development

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add param to extend the ego footprint+fixed overlaps+started intervals

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Implemented basic stop points insertion. "working" with simplified logic

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Combine overlap and interval calculation, 1st rough working version

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add more parameters to replace magic numbers

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* [WIP] cleanup bugs and add a few more params

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Proper stop point insertion (such that there are no overlaps)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add interval visualization, fix bugs

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Major refactoring and preparing params for 3rd method (TTC)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Implement TTC + more refactoring (not tested)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix issue with calculating enter/exit time of object after it entered

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix bug in calculating ego distance along path

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add option to skip the new module if ego already overlaps another lane

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Implement decel limit and add some (unimplemented) parameters

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Implement the "strict" parameter (dont stop while overlapping)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Implement "use_predicted_paths" param (not yet tested)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Filter lanelets used for checking overlaps

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix calculation of enter/exit times using predicted paths of objects

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Improve "skip_if_already_overlapping" logic and add debug markers

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Use dist(left, right) for inside distance when both bounds are overlaped

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add fallback when a point with no overlap cannot be found

Fallback: use the path index previous to the range's entering path index

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Increase max lateral deviation of predicted paths + add debug prints

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix logic for select path_lanelets and other_lanelets + debug markers

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Improve object filtering by their lateral distance from overlap range

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Rename length -> dist in object_time_to_range function

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Cleanup code and improve use of planner_data_

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add overlapping_range.cpp + code cleanup

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add decisions.hpp + code cleanup

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add footprint.cpp

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Cleanup and factorize more code

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add docstring + final factorization

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Remove debug changes in behavior_planning.launch.py

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add out of lane design document (WIP)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Extend design doc and lint it

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Finalize 1st draft of design doc (figures are missing)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add figures

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix some clang-tidy errors

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Factorize the calculate_decisions function

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix spelling relevent -> relevant

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Add debug.hpp and debug.cpp to simplify createDebugMarkerArray()

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Factorize calculate_slowdown_points

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Factorize decisions.cpp a little more

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix for clang tidy

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Factorize decisions.cpp a little bit more

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Update copyright

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* Update copyright

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* Update copyright

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* Fix copyrights Tier IV -> TIER IV

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Populate StopReason

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Set VelocityFactor

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix design doc title

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Populate StopReason only when stopping (not when slowing down)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Remove default value for declare_parameter of 'launch_run_out'

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…er specified seconds (autowarefoundation#3292)

* feat(autonomous_emergency_braking): keep collision information for user specified seconds

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…autowarefoundation#3058)

* rebase on to master
add scan_frame and raytrace center

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* rebase to main

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix config and launch file

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fixed laserscan based launcher

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add filter func to extract obstacle pc in sensor

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add switchable launcher

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* back to pointcloud based method
and fix missing }

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* remove unused launch.py

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: fix and refactor launch.py

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* document: update README

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* enable to change origins by lanch args

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…undation#3332)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…owarefoundation#3331)

* refactor(behavior_path_planner): separate safety check from util

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* revert non related getPredictedPathFromObj

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
…t' (autowarefoundation#3333)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…autowarefoundation#3327)

only zero hold velocity

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…3127)

* delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>

* fix(mission_planner): add type

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_centerline_optimizer): add mission planner param path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

---------

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: wep21 <wep21@users.noreply.github.com>
…ion#3321)

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
…ion#3340)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.52 🎉

Comparison is base (15906f0) 4.74% compared to head (93e040a) 5.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff              @@
##           tier4/main    #355      +/-   ##
=============================================
+ Coverage        4.74%   5.27%   +0.52%     
=============================================
  Files             169     235      +66     
  Lines           17393   21730    +4337     
  Branches         9390   10677    +1287     
=============================================
+ Hits              826    1147     +321     
- Misses          15818   19529    +3711     
- Partials          749    1054     +305     
Flag Coverage Δ
differential 5.27% <0.00%> (+0.52%) ⬆️
Impacted Files Coverage Δ
...king/include/autonomous_emergency_braking/node.hpp 0.00% <0.00%> (ø)
control/autonomous_emergency_braking/src/node.cpp 0.00% <0.00%> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...anner/util/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...nclude/behavior_path_planner/util/safety_check.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 100.00% <ø> (+16.66%) ⬆️
...or_path_planner/src/behavior_path_planner_node.cpp 0.11% <0.00%> (-0.01%) ⬇️
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...ane_change/external_request_lane_change_module.cpp 0.00% <0.00%> (ø)
... and 21 more

... and 47 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 0d0a952 into tier4/main Apr 11, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch April 11, 2023 01:27
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
* ci(update-docker-manifest): create aliases for CUDA images

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.