feat(control): add autonomous emergency braking module (backport #2793, #3186, #3248, #3292) #330
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## beta/v0.3.15 #330 +/- ##
===============================================
Coverage ? 10.09%
===============================================
Files ? 506
Lines ? 40832
Branches ? 8508
===============================================
Hits ? 4124
Misses ? 32994
Partials ? 3714
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…er specified seconds (autowarefoundation#3292) * feat(autonomous_emergency_braking): keep collision information for user specified seconds * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta
changed the title
h-ohta
requested review from
0x126,
YoheiMishina and
yn-mrse
and removed request for
0x126
| bool checkExpired() | ||
| { | ||
| if (data_ && (clock_->now() - data_->stamp).seconds() > timeout_sec_) { | ||
| data_.reset(); | ||
| } | ||
| return (data_ == nullptr); | ||
| } |
There was a problem hiding this comment.
Changing internal variables with the bool type check function is not recommended, as it may lead to misunderstandings by maintenance personnel or human error.
Since this is a backport PR, no fix action is required in this PR.
Description
motion_utilstotier4_autoware_utilsin code because it does not existboost_polygon_utilsRelated Links
https://tier4.atlassian.net/browse/T4PB-25351
https://github.com/tier4/autoware_launch.x1.eve/pull/379
Test performed
I confirmed in https://tier4.atlassian.net/wiki/spaces/SI/pages/2752285412/2023-04-10+AEB .
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.