Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_auto_perception_rviz_plugin): add simple visualize mode (autowarefoundation#2814) #271

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Feb 6, 2023

Description

Hotfix to beta/v0.7.0. Improve performance of rviz.

autowarefoundation#2780
autowarefoundation#2814

Add simple visualization mode to autoware_auto_perception_rviz_plugin for reduction of visualization cost.
Compared to before the PR merge, there is no change when using default parameters.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

lexavtanke and others added 2 commits February 6, 2023 16:04
…utowarefoundation#2780)

* add choose box element to control type of visualization polygon for detected objects

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* WIP: add switching logic and defininition for 2d poligons functions, working

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* add function for making 2d polygon from cylinder shape

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* add code to make 2d polygones from unknown objects

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* wip, add creation of milty dummy objects by one click

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* modificate empty_objects_publisher for testing purpose

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* feat/2d_obj_rviz: cleaning for pull request. Remove dummy_empty_obj.launch and revert testing modification.

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* feat/2d-obj-rviz refactor, update names of functions to more meaningfull, remove unnecessary code which was drawing additional lines on circle, remove TODO

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* style(pre-commit): autofix

* feat/2d-obj-rviz correct spelling mistakes

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

---------

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…autowarefoundation#2814)

* feat(autoware_auto_perception_rviz_plugin): add simple visualize mode

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix typo

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 766d9e4 into beta/v0.7.0 Feb 6, 2023
@tkimura4 tkimura4 deleted the feat/add_simple_vis_mode branch February 6, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants