perf(autoware_detected_object_validation): reduce lanelet_filter processing time (#8240) #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essing time (autowarefoundation#8240) * add local r-tree for fast searching Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> change to _func__ add more debug use local rtree fix tmp update fix bug clean unused clean up Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * clean up Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * style(pre-commit): autofix * chore: Optimize object filtering and improve performance The code changes in `lanelet_filter.cpp` optimize the object filtering process by using the `empty()` function instead of checking the size of the `transformed_objects.objects` vector. This change improves performance and simplifies the code logic. Refactor the code to use `empty()` instead of `size()` for checking if the `transformed_objects.objects` vector is empty. This change improves readability and performance. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
requested review from
badai-nguyen,
Shin-kyoto,
miursh,
YoshiRi and
yukkysaito
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry-pick of autowarefoundation#8240
https://tier4.atlassian.net/browse/RT1-7219
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.