Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): port the algorithm to get lane_ids from path to beta/v0.4.1 #129

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Sep 15, 2022

Description

cherry-pick and resolve conflicts

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…rivate_area (#1323)

* fix(behavior_velocity_planner): sort unique_lane_ids for merge_from_private_area

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* use same function

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Apply suggestions from code review

* fix

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Apply suggestions from code review

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…m path (autowarefoundation#1594)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link

@s-azumi s-azumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed in this ticket that the issue has been fixed.
https://tier4.atlassian.net/browse/T4PB-20938

@s-azumi s-azumi merged commit dea36ab into beta/v0.4.1 Sep 16, 2022
@s-azumi s-azumi deleted the fix/s1_stop_line branch September 16, 2022 10:30
tkimura4 pushed a commit that referenced this pull request Oct 24, 2022
* support x1 perception config

* remove product config

* update launch.py

* maintain some filters params in yaml file

* add function to create elevation map pipeline

* add param to yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants