Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnss_poser): cherry pick #1263

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

0x126
Copy link

@0x126 0x126 commented Apr 18, 2024

Description

Cherry-pick bug fixes for gnss_poser

Related Links

Tests performed

Checked param and topics

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

KYabuuchi and others added 2 commits April 18, 2024 15:38
…on#6116)

* remove gnss_frame param & use header.frame_id to get anntenna's frame_id

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* update README

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@0x126 0x126 requested a review from TomohitoAndo April 18, 2024 07:17
@0x126 0x126 changed the title fix(gnss poser): cherry pick fix(gnss_poser): cherry pick Apr 18, 2024
@0x126 0x126 requested review from saka1-s and removed request for YamatoAndo and kminoda April 18, 2024 07:22
@0x126 0x126 merged commit 755e422 into beta/v0.19.1 Apr 18, 2024
16 of 18 checks passed
@0x126 0x126 deleted the chore/gnss_poser/cherry-pick branch April 18, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants