Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tier4_simulator_launch_param_path is conflicting a file path #182

Closed
3 tasks done
Yukio247 opened this issue Nov 14, 2022 · 3 comments · Fixed by autowarefoundation/autoware.universe#2281
Closed
3 tasks done
Assignees

Comments

@Yukio247
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

An environment variable name tier4_simulator_launch_param_pathis defined HERE.
And the name is used in HERE. You can see the config directory is conflicting.
When I tried to use fault injection in the scenario simulator, I could not use the fault injection because of duplicate "config" directories.

Expected behavior

I can use Fault Injection in the scenario simulator.

Actual behavior

I cannot use Fault Injection in the scenario simulator.

Steps to reproduce

  1. Run scenario simulator.
  2. Publish a something fault injection.

Versions

No response

Possible causes

No response

Additional context

No response

@kminoda
Copy link

kminoda commented Nov 14, 2022

@Yukio247
Thank you for reporting, and sorry for my mistake. I did not test this modification on scenario simulator since it was a simple change.
I opened a PR to fix this issue: autowarefoundation#2281, which eventually will be merged into tier4/main branch in this repos.

@shmpwk
Copy link
Collaborator

shmpwk commented Nov 14, 2022

Maybe we should change this also?
https://github.com/tier4/autoware_launch/blob/awf-latest/simulator_launch/launch/simulator.launch.xml#L18

No problem there

@shmpwk
Copy link
Collaborator

shmpwk commented Nov 14, 2022

autowarefoundation#2281 will be merged into tier4/main branch in this repos by #181.

PLZ wait for a while CI is checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants