Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in Eqn. (20) #3

Closed
jerabaul29 opened this issue Dec 27, 2020 · 2 comments
Closed

typo in Eqn. (20) #3

jerabaul29 opened this issue Dec 27, 2020 · 2 comments

Comments

@jerabaul29
Copy link

Hi @thw1021 .

@jviquerat found a small typo in the paper. In Eqn. (20), this should be rather something like:

c_i=a_{j−1}+ i *(a_j−a_{j−1}) / Ne

or something like this, right? I.e., there is a i missing at the numerator of the fraction part, right?

This is not a big worry at all, small typos in this kind happen all the time, but would be great to mention it. Can you add on the readme of the present repo a "Typos in the paper" section, a bit like what is written at the end of the readme at https://github.com/jerabaul29/Cylinder2DFlowControlDRL , where you show the correct equation, and mention that this has always been correctly implemented in the code and is purely a typo? :) .

@jerabaul29
Copy link
Author

And many thanks @jviquerat for reading the paper carefully, noticing the problem, and letting us know :) .

@thw1021
Copy link
Owner

thw1021 commented Dec 28, 2020

Yes, I have added an explanation. Thank you @jerabaul29 @jviquerat

@thw1021 thw1021 closed this as completed Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants