Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_release: Fix issue with draft releases no showing up #2388

Closed
jku opened this issue May 9, 2023 · 1 comment · Fixed by #2389
Closed

verify_release: Fix issue with draft releases no showing up #2388

jku opened this issue May 9, 2023 · 1 comment · Fixed by #2389

Comments

@jku
Copy link
Member

jku commented May 9, 2023

I think at some point I made the verify_release use "draft:true" when uploading the draft release, instead of modifying the name.
This was a mistake as already documented by lukas in #1933:

It would be nice if we could set the release as draft at first, but that has the same caveat, i.e. it requires a token and special knowledge to download the assets.

so what happens is that while the release is a draft ./verify_release -- skip-pypi does not notice that a new GitHub release exists:

./verify_release --skip-pypi
* Built release 3.0.0
* WARNING: GitHub latest version is 2.1.0
* ERROR: GitHub artifacts do not match built release

Easiest fix would be to revert using "draft:true".

@jku
Copy link
Member Author

jku commented May 9, 2023

the bug is part of this commit:
707dc49 (note both draft:true and the name changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant