Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all TODO items in the new implementation prior to 1.0.0 #1764

Closed
MVrachev opened this issue Jan 11, 2022 · 3 comments
Closed

Review all TODO items in the new implementation prior to 1.0.0 #1764

MVrachev opened this issue Jan 11, 2022 · 3 comments
Assignees
Labels
1.0.0 blockers To be addressed before 1.0.0 release
Milestone

Comments

@MVrachev
Copy link
Collaborator

Description of issue or feature request:
We have multiple TODO items in the source code inside the new implementation and it will be good to review them one by one and decide if we want to fix them now or leave them.
If we decide to leave them it will be good to create separate issues (where it makes sense) or group them in one summarization issue.

@MVrachev MVrachev added the 1.0.0 blockers To be addressed before 1.0.0 release label Jan 11, 2022
@jku
Copy link
Member

jku commented Jan 12, 2022

For Metadata API:

  • 2 TODOs about pylint: disable=too-many-arguments. Let's remove the TODOs, in my opinion the lint is useful in most situations but not here so the disables are fine
  • TODO about serialization error location: this could be an issue of its own, and relates to the other exception work going on. IMO the errors should be in the common exceptions file because metadata API users have to handle deserializationerror (it's not an internal error)

@jku
Copy link
Member

jku commented Jan 12, 2022

The ngclient TODOs should get handled by #1312, #1761 and #1714

@jku jku added this to the Sprint 15 milestone Jan 12, 2022
@jku jku self-assigned this Jan 12, 2022
@jku jku modified the milestones: Sprint 15, sprint 16 Jan 26, 2022
@jku
Copy link
Member

jku commented Feb 3, 2022

Closing as #1794, #1805 are closed and #1804 has been filed

@jku jku closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 blockers To be addressed before 1.0.0 release
Projects
None yet
Development

No branches or pull requests

2 participants