Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtests: add tests toggling consistent snapshot #1667

Closed
sechkova opened this issue Nov 8, 2021 · 1 comment · Fixed by #1666
Closed

ngtests: add tests toggling consistent snapshot #1667

sechkova opened this issue Nov 8, 2021 · 1 comment · Fixed by #1666
Assignees
Labels
backlog Issues to address with priority for current development goals testing
Milestone

Comments

@sechkova
Copy link
Contributor

sechkova commented Nov 8, 2021

Description of issue or feature request:
Currently different configurations of consistent_snapshot, prefix_targets_with_hash are tested in test_updater_ng.py which uses pre-generated test files.

After adding support for non-consistent snapshot #1637, analyze what would be meaningful consistent snapshot tests that preferably don't duplicate the tests code for each config and implement them using RepositorySimulator.

@jku
Copy link
Member

jku commented Nov 10, 2021

After adding support for non-consistent snapshot #1637, analyze what would be meaningful consistent snapshot tests that preferably don't duplicate the tests code

Sounds good.
I think it's reasonable to concentrate testing on

  • consistent_snapshot with consistent targets
  • consistent_snapshot without consistent targets (the special case for warehouse)

and leave the non-consistent_snapshot case with just the minimum tests to verify it works: everyone should be using consistent_snapshot, we only support the other case because the spec still allows it.

@sechkova sechkova added the backlog Issues to address with priority for current development goals label Nov 10, 2021
@sechkova sechkova added this to the Sprint 12 milestone Nov 10, 2021
@sechkova sechkova self-assigned this Nov 10, 2021
@jku jku closed this as completed in #1666 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants