-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RepositorySimulator: add support for serving invalid metadata #1615
Comments
let's talk about these: I think these are mostly already doable -- but it's true the methods to do so might not be very accessible.
|
Thanks for expanding on the bullets, I managed to apply all these successfully in #1636. Only one issue remained, partially related to consistent snapshot. Since
The only idea I got is to test this when I plan to close this issue and open another one for implementing the above. |
yeah I see. The simulator does not in any way "publish" non-root metadata so when a request is made it just checks if the requested version matches current metadata... I guess one option is to just not check for the version match in the simulator: instead always return the current metadata, whatever version is requested. I have no idea if this would complicate some other tests, but I remember originally adding the check only to test that the simulator works... maybe it isn't needed? |
I will add these notes to #1637 to test if removing the check causes any problems with consistent/non-consistent snapshot. I did actually run my tests with commenting out the check you mention and nothing wrong happened ... |
Is this still an issue with the changes in #1636? |
Description of issue or feature request:
update: One scenario of invalid metadata remains, serving a snapshot whose version does not match the one in timestamp.snapshot_meta and targets whose version does not match the one in snapshot.meta respectively (see discussion below).
In many test scenarios there is a need of serving various forms of invalid metadata:
Current behavior:
All metadata is served signed, hard to tweak signatures, hard to tweak hashes.
Expected behavior:
Add options and/or methods to RepositorySimulator facilitating serving invalid metadata.
The text was updated successfully, but these errors were encountered: