Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "page.waitFor" with "page.waitForTimeout" #4

Closed
johansmith90 opened this issue Sep 22, 2020 · 2 comments
Closed

Replace "page.waitFor" with "page.waitForTimeout" #4

johansmith90 opened this issue Sep 22, 2020 · 2 comments

Comments

@johansmith90
Copy link

johansmith90 commented Sep 22, 2020 •
edited
Loading

Running await.collector currently causes a depreciation warning from puppeteer to be logged to the console every time waitFor is called with puppeteer@5.2.1.

waitFor is deprecated and will be removed in a future release. See puppeteer/puppeteer#6214 for details and how to migrate your code

Replacing page.waitFor with page.waitForTimeout in the following files should remove this depreciation warning:

  • src/pptr-utils/interaction-utils.ts
  • src/collector.ts
  • tests/key-logging.ts

Happy to submit a PR if you're accepting them.
@samatt
Copy link
Contributor

samatt commented Sep 24, 2020

Thanks, yeah I noticed this when I upgraded to 5.2.1, will fix on the next release

@simonft
Copy link
Contributor

simonft commented Mar 29, 2023

Fixed in #30. Thanks for the report!

@simonft simonft closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonft @samatt @johansmith90