Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff styling for stdlib & jll (faded) #47

Closed
tfiers opened this issue Jan 2, 2023 · 5 comments
Closed

Diff styling for stdlib & jll (faded) #47

tfiers opened this issue Jan 2, 2023 · 5 comments
Labels
feature An enhancement to src/ visible to end-users
Milestone

Comments

@tfiers
Copy link
Owner

tfiers commented Jan 2, 2023

New option; set by default.

I.e. stdlib and jll can be true, faded, false.

Hm or even more: could also have :comment or :invisible or sth: keep in src, but not in img

@tfiers tfiers added the feature An enhancement to src/ visible to end-users label Jan 2, 2023
@tfiers
Copy link
Owner Author

tfiers commented Jan 4, 2023

stdlib = :faded
stdlib = :hidden
stdlib = :normal

so, is hidden commented out?
what then to name when totally expunged (shorter url is one advantage).
stdlib = :ignore ?

@tfiers
Copy link
Owner Author

tfiers commented Jan 4, 2023

of maybe
:show en :show_faded.

ofc, the default is :auto, ye.
(if requested pkg is itself in stdlib, then yes. e.g.)

so: :hide, :show, :show_faded, :auto

(of mss :show_normal, :show_faded)

or do we just not comment. why keep in src?
ah as info, ok. yeah sure.

@tfiers
Copy link
Owner Author

tfiers commented Jan 4, 2023

:hide
:show
:fade
:remove
:auto

The default is :auto, which will choose between these four depending on the package and its dependencies.

itself in stdlib: show
(hm wait. I don't like having both show and faded. Cause here i said show but meant show_faded (but that's too long))
So better to have a consistent 'colour' scheme.

..ooh! yes :) Much better.
A consistent scheme (and ofc customizable).
same for jll and stdlib? sure.
diff would be cool; but then what do when iz both.
(ooooh. you could combine. hehe: fade (transpa?) for stdlib; and colour (green text & circle eg) for jll)
beautiful!

@tfiers
Copy link
Owner Author

tfiers commented Jan 4, 2023

So yeah there's then three options (plus auto).

jll: One of :hide, :show, :remove, or :auto (default).
- :hide does not draw nodes in the graph for JLL libraries, but still leaves them as commented-out entries in the dot-string
- :remove also removes them from the dot-string (useful to make urls for big packages shorter).
- :auto chooses between the other three. See jll_handling_method(pkg, options)

..which does:

  • in stdlib? show stdlib
  • very many deps? (quantified by lil triar and error ig; to not get Plots.jl noodle) then:
    • local? (well, doesn't matter: user don't see the str anyway)
    • online, and if without is within urlopen bounds, then without.
      • if it's too long even without, then we have to copy paste anyway and may just as well include them right. hm or mayb no, as obstructs overview, or sth

@tfiers tfiers changed the title stdlib = :faded Diff styling for stdlib & jll (faded) Jan 5, 2023
@tfiers tfiers added this to the v1 milestone Jan 14, 2023
@tfiers
Copy link
Owner Author

tfiers commented Jan 14, 2023

Very easy, with A -> Pkg [color=gray] and Pkg -> B [color=gray],
and Pkg [color=gray fontcolor=gray] at bottom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement to src/ visible to end-users
Projects
None yet
Development

No branches or pull requests

1 participant