Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): add home and end to specialChars enum #569

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix(typings): add home and end to specialChars enum #569

merged 2 commits into from
Mar 2, 2021

Conversation

jKatt
Copy link
Contributor

@jKatt jKatt commented Mar 2, 2021

What: Added home and end to the specialChars enum in typings

Why: In PR #536 home and end typings were not added, so specialChars.home could not be used with typescipt

How: added the missing typings

Checklist:

  • Documentation N/A
  • Tests N/A
  • Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #569 (d8e6fa7) into master (090566c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #569   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          717       717           
  Branches       226       226           
=========================================
  Hits           717       717           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090566c...2150ea3. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 481e764 into testing-library:master Mar 2, 2021
@ph-fritsche
Copy link
Member

Thanks a lot for taking the time to contribute to this library :)

@allcontributors add @jKatt code

@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @jKatt! 🎉

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

🎉 This PR is included in version 12.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants