Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): fixed bugs in prefer-to-have-style & prefer-in-document #115

Merged
merged 10 commits into from
Dec 2, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Dec 1, 2020

What: fixing more use cases from smoke tests

Why: less bugs
fixes: #110
fixes: #114

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #115 (fd86d47) into master (a030ec5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          238       247    +9     
  Branches        32        37    +5     
=========================================
+ Hits           238       247    +9     
Impacted Files Coverage Δ
src/rules/prefer-in-document.js 100.00% <100.00%> (ø)
src/rules/prefer-to-have-style.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a030ec5...fd86d47. Read the comment docs.

@benmonro benmonro changed the title fix(prefer-in-document): more fixes to prefer-in-document fix(rules): fixed bugs in prefer-to-have-style & prefer-in-document Dec 1, 2020
@benmonro benmonro merged commit c397bd1 into master Dec 2, 2020
@benmonro benmonro deleted the feature/more-document-fixes branch December 2, 2020 01:06
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-in-document handle AllBy queries expect.objectContaining support in toHaveStyle
1 participant