Add health check logging support #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dev <Dev25@users.noreply.github.com>
Signed-off-by: Dev <Dev25@users.noreply.github.com>
Signed-off-by: Dev <Dev25@users.noreply.github.com>
morgante
approved these changes
May 5, 2020
custodianbot
referenced
this pull request
in bycustodian/terraform-google-lb-http
Jul 22, 2022
cause this is not enough to use this module from the public registry
```
module "sql-db" {
source = "GoogleCloudPlatform/sql-db/google"
version = "3.1.0"
}
```
This warn help us, but can be more explicit :
This module version (...) has no root configuration. A module with no root configuration cannot be used directly.
Use the submodules dropdown above to view the 4 submodules defined within this module.
So add a small usage guideline in the readme with remote usage can help us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cloud.google.com/load-balancing/docs/health-check-logging
https://github.com/terraform-providers/terraform-provider-google/releases/tag/v3.17.0
3.17 added beta support (we already use beta provider in this module) for setting health check logging, this also means we drop 2.x provider compatibility.