Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform v0_12 module #4

Merged
merged 6 commits into from
Jul 21, 2019
Merged

Conversation

bamaralf
Copy link
Contributor

No description provided.

@e-moshaya
Copy link

do you have an estimate when this will be merged?

@antonbabenko
Copy link
Member

Hopefully closer to the end of this week or during weekends.

@e-moshaya
Copy link

@antonbabenko any update on this?

@e-moshaya
Copy link

very eager to start using this module, please can I get an update?

@e-moshaya
Copy link

would also be nice to have an optional create_bucket variable to enable/disable module similar to the create_vpc variable in https://github.com/terraform-aws-modules/terraform-aws-vpc

}
}

dynamic "server_side_encryption_configuration" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a terraform fmt on this file?

@antonbabenko antonbabenko merged commit dc9864d into terraform-aws-modules:master Jul 21, 2019
@antonbabenko
Copy link
Member

Thanks @bamaralf and other reviewers!

v0.0.1 has been just released.

This module requires some more improvements before it can be v1.0.0. I will make those in August when I am back from vacations.

@bamaralf
Copy link
Contributor Author

bamaralf commented Jul 25, 2019 via email

yarda7 pushed a commit to yarda7/terraform-aws-s3-bucket that referenced this pull request Jan 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants