feat: Update object_ownership variable description #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `BucketOwnerEnforced` value with a description to available options.
Due to the introduction of the new setting for S3 Bucket Ownership
By adding information about the new S3 Ownership setting BucketOwnerEnforced
bryantbiggs
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Looks good - was confused on the version bump but I see its tied to the underlying AWS SDK usage so it must be bumped. Thanks for the PR @tsybanov !
tsybanov
changed the title
|
Thanks, @bryantbiggs! Any thoughts on changing the default setting of the Object Ownership to |
antonbabenko
pushed a commit
that referenced
this pull request
Jan 12, 2022
## [2.12.0](v2.11.2...v2.12.0) (2022-01-12) ### Features * Update object_ownership variable description ([#121](#121)) ([ce9e719](ce9e719))
|
This PR is included in version 2.12.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update description of the
object_ownershipvariable by adding information about theBucketOwnerEnforcedoption.Motivation and Context
On November 30, 2021, Amazon announced a new S3 Object Ownership setting,
BucketOwnerEnforced.Ref. https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-s3-object-ownership-simplify-access-management-data-s3/
The new setting already has been integrated into AWS provider in v.3.69.0
Ref. hashicorp/terraform-provider-aws#21980
Also, we might consider setting the default value to the
BucketOwnerEnforcedas per AWS recommendation.Ref. https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html
Breaking Changes
How Has This Been Tested?
examples/*projectsThe change has been tested in production with updated AWS provider to v.3.69.0