Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] lower oracle feeder cost #463

Merged
merged 14 commits into from
Mar 18, 2021
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 18, 2021

Summary of changes

Two main updates to lower the oracle feed cost.

  • Allow oracle messages can be submitted only from the active validator set & also check feeder right.
  • Ante handler also only allow 1 msg per 1 block for a validator.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim March 18, 2021 07:11
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #463 (6a3193c) into master (c066211) will increase coverage by 0.14%.
The diff coverage is 84.33%.

❗ Current head 6a3193c differs from pull request most recent head 1bda73e. Consider uploading reports for the commit 1bda73e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   67.22%   67.37%   +0.14%     
==========================================
  Files         119      119              
  Lines        5138     5186      +48     
==========================================
+ Hits         3454     3494      +40     
- Misses       1463     1471       +8     
  Partials      221      221              
Impacted Files Coverage Δ
x/oracle/internal/types/test_utils.go 52.08% <0.00%> (-1.11%) ⬇️
x/oracle/internal/keeper/keeper.go 82.60% <69.23%> (-0.90%) ⬇️
x/auth/ante/spamming_prevention.go 73.46% <78.94%> (-11.15%) ⬇️
app/app.go 87.04% <100.00%> (+0.34%) ⬆️
x/auth/ante/ante.go 100.00% <100.00%> (ø)
x/auth/ante/tax.go 79.10% <100.00%> (+2.83%) ⬆️
x/oracle/handler.go 90.69% <100.00%> (+3.11%) ⬆️
x/oracle/tally.go 93.02% <0.00%> (+4.65%) ⬆️

hanjukim
hanjukim previously approved these changes Mar 18, 2021
Copy link
Contributor

@hanjukim hanjukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanjukim
Copy link
Contributor

Please add some contents to the CHANGELOG

@yun-yeo yun-yeo changed the title Feature/spamming protection [Feature] lower oracle feeder cost Mar 18, 2021
@yun-yeo
Copy link
Contributor Author

yun-yeo commented Mar 18, 2021

Please add some contents to the CHANGELOG

applied here: #457

@yun-yeo yun-yeo requested a review from hanjukim March 18, 2021 10:17
@yun-yeo yun-yeo added daemon daemon updates enhancement New feature or request labels Mar 18, 2021
hanjukim
hanjukim previously approved these changes Mar 18, 2021
@hanjukim hanjukim self-requested a review March 18, 2021 10:48
@yun-yeo yun-yeo merged commit 534de88 into master Mar 18, 2021
@yun-yeo yun-yeo deleted the feature/spamming-protection branch March 18, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon daemon updates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants