Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common device/driver implementations to base tt_device class #26

Open
vtangTT opened this issue Aug 5, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@vtangTT
Copy link
Contributor

vtangTT commented Aug 5, 2024

std::uint64_t tt_SimulationDevice::get_pcie_base_addr_from_device()
virtual void set_device_l1_address_params(const tt_device_l1_address_params& l1_address_params_);
virtual void set_device_dram_address_params(const tt_device_dram_address_params& dram_address_params_);
virtual void set_driver_host_address_params(const tt_driver_host_address_params& host_address_params_);
virtual void set_driver_eth_interface_params(const tt_driver_eth_interface_params& eth_interface_params_);

These ones are common among tt_SiliconDevice, tt_SimulationDevice, tt_EmulationDevice. There might be more.

FYI: @joelsmithTT

@vtangTT vtangTT added the enhancement New feature or request label Aug 5, 2024
@vtangTT vtangTT self-assigned this Aug 5, 2024
@joelsmithTT
Copy link
Contributor

There may be fields in the tt_..._params structures that are unused, so there's an opportunity for some cleanup/consolidation here.

Also related: the error messages from tt_SiliconDevice are bad if a code path expects set_driver_eth_interface_params to have been previously called.

I think there is an opportunity here to make tt_SiliconDevice more difficult to use incorrectly.

@broskoTT
Copy link
Contributor

Let's wait a bit to get clarity from #57
The future design does address having a base Chip class with common implementation (In the design, tt_SiliconDevice = LocalChip + RemoteChip, tt_SimulationDevice = VersimChip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants