Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.0 Regression: PullRequestResource missing base PR information #1681

Closed
wlynch opened this issue Dec 4, 2019 · 1 comment · Fixed by #1685
Closed

0.9.0 Regression: PullRequestResource missing base PR information #1681

wlynch opened this issue Dec 4, 2019 · 1 comment · Fixed by #1685
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@wlynch
Copy link
Member

wlynch commented Dec 4, 2019

/kind bug
/assign wlynch

Expected Behavior

Reported by thauta on Slack.

Full PullRequest data is available in the pipeline (in particular merge state and SHA)

Actual Behavior

The data is not there (only head/base, labels, statuses are there). This is a regression from 0.8.

Additional Info

If we include the full payload, We'll need to make sure to not conflict with the broken out subresources - e.g. should we have labels in both pr.json and labels/, and how do these interact with each other.

My gut reaction is to omit these from pr.json.

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2019
@vdemeester vdemeester added this to the Pipelines 0.9.1 🐱 milestone Dec 4, 2019
@vdemeester
Copy link
Member

@wlynch tentatively adding this to the 0.9.1 milestone 👼 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants