Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit client libraries for external usage #1044

Open
Tracked by #780
aaron-prindle opened this issue Feb 1, 2024 · 1 comment
Open
Tracked by #780

Limit client libraries for external usage #1044

aaron-prindle opened this issue Feb 1, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@aaron-prindle
Copy link
Contributor

This issue tracks the work required to limit tektoncd/chains usage as a client library. Currently some methods/structs are exposed to users that we don't want to be public (eg: don't want them to depend-on/use). Work required is likely a refactor to make some currently public methods, interfaces, structs, etc. private

@aaron-prindle aaron-prindle added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2024
@aaron-prindle aaron-prindle mentioned this issue Feb 1, 2024
7 tasks
@aaron-prindle
Copy link
Contributor Author

Analysis on tektoncd/chains usage as a client library externally. The below methods are those that are relied on for client library external usage to be considered/hopefully-kept-available when limiting client libraries:

"github.com/tektoncd/chains/pkg/chains/formats/formats”

  • formats.GetPayloader
  • formats.PayloadTypeSlsav2alpha3

"github.com/tektoncd/chains/pkg/chains/objects/objects"

  • objects.TektonObject
  • objects.NewPipelineRunObjectV1
  • objects.NewTaskRunObjectV1

"github.com/tektoncd/chains/pkg/config/config"

  • config.Config
  • config.BuilderConfig
  • config.ArtifactConfig
  • config.BuildDefinitionConfig

"github.com/tektoncd/chains/pkg/chains/formats/slsa/extract/extract"

  • extract.RetrieveAllArtifactURIs

"github.com/tektoncd/chains/pkg/chains/formats/slsa/v2alpha3/v2alpha3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant