Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if patches directories match the contents of patches.json #375

Closed
estellecomment opened this issue Jan 16, 2023 · 1 comment
Closed

Check if patches directories match the contents of patches.json #375

estellecomment opened this issue Jan 16, 2023 · 1 comment
Assignees
@aulamber
Labels
devops P3 Priority 3 web

Comments

@estellecomment
Copy link
Contributor

It seems to be possible to have dirs in patches which are not present in patches.json, and the scripts do not complain.
This should not be possible, so make the scripts crash in this case.
@github-actions github-actions bot added the web label Jan 16, 2023
@estellecomment estellecomment mentioned this issue Jan 16, 2023
Merged
43 tasks
@aulamber aulamber self-assigned this Mar 29, 2023
@aulamber aulamber mentioned this issue Mar 29, 2023
Merged
@aulamber aulamber added the P3 Priority 3 label Mar 30, 2023
@odelcroi odelcroi added the devops label Apr 4, 2023
@odelcroi
Copy link
Member

odelcroi commented May 3, 2023

Could not reproduce, if a folder is added in patches/, the script complains if there is no matching entry in patches.json

@odelcroi odelcroi closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aulamber aulamber

Labels
devops P3 Priority 3 web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estellecomment @odelcroi @aulamber