Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NoteMessage.fixItID to noteID #2261

Closed
ahoppen opened this issue Oct 4, 2023 · 1 comment · Fixed by #2264
Closed

Rename NoteMessage.fixItID to noteID #2261

ahoppen opened this issue Oct 4, 2023 · 1 comment · Fixed by #2264
Assignees
@kimdv
Labels
bug Something isn't working

Comments

@ahoppen
Copy link
Member

ahoppen commented Oct 4, 2023 •
edited
Loading

NoteMessage having a property named fixItID was a stupid copy-paste error. I should be named noteID.

We need to consider how to mitigate API-breakage impact from this change, but AFAICT we will need to have an API-breaking change to rename the property. But maybe there is some clever way to avoid the API breakage.
@ahoppen ahoppen added the bug Something isn't working label Oct 4, 2023
@ahoppen
Copy link
Member Author

ahoppen commented Oct 4, 2023

Tracked in Apple’s issue tracker as rdar://116485448

@kimdv kimdv self-assigned this Oct 5, 2023
@kimdv kimdv mentioned this issue Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimdv kimdv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename NoteMessage.fixItID to noteID kimdv/swift-syntax
2 participants
@ahoppen @kimdv