fix(core): respect useDefineForClassFields tsconfig value #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Brooooooklyn
approved these changes
Nov 14, 2023
Brooooooklyn
changed the title
austinbiggs
referenced
this pull request
in austinbiggs/ivy
Feb 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@swc-node/register](https://github.com/swc-project/swc-node) | [`1.6.8` -> `1.8.0`](https://renovatebot.com/diffs/npm/@swc-node%2fregister/1.6.8/1.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>swc-project/swc-node (@​swc-node/register)</summary> ### [`v1.8.0`](https://github.com/swc-project/swc-node/releases/tag/%40swc-node/register%401.8.0) [Compare Source](https://github.com/swc-project/swc-node/compare/@swc-node/register@1.6.8...@swc-node/register@1.8.0) #### What's Changed - fix(core): remove `jsc.module.noInterop` when it's not supported by [@​kdy1](https://github.com/kdy1) in [https://github.com/swc-project/swc-node/pull/733](https://github.com/swc-project/swc-node/pull/733) - chore: fix README for install, build, and test by [@​devjiwonchoi](https://github.com/devjiwonchoi) in [https://github.com/swc-project/swc-node/pull/728](https://github.com/swc-project/swc-node/pull/728) - feat(register): @​swc-node/register/esm use TypeScript resolver by [@​cm-ayf](https://github.com/cm-ayf) in [https://github.com/swc-project/swc-node/pull/727](https://github.com/swc-project/swc-node/pull/727) - chore(deps-dev): bump [@​babel/traverse](https://github.com/babel/traverse) from 7.22.10 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/735](https://github.com/swc-project/swc-node/pull/735) - Fix [#​716](https://github.com/swc-project/swc-node/issues/716) by [@​eliellis](https://github.com/eliellis) in [https://github.com/swc-project/swc-node/pull/725](https://github.com/swc-project/swc-node/pull/725) - chore(deps-dev): bump axios from 1.3.5 to 1.6.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/738](https://github.com/swc-project/swc-node/pull/738) - fix(core): respect useDefineForClassFields tsconfig value by [@​dsyddall](https://github.com/dsyddall) in [https://github.com/swc-project/swc-node/pull/740](https://github.com/swc-project/swc-node/pull/740) - fix(core): respect sourceMaps swcrc value by [@​dsyddall](https://github.com/dsyddall) in [https://github.com/swc-project/swc-node/pull/742](https://github.com/swc-project/swc-node/pull/742) - feat: add esm-register for node>20.6 by [@​yeliex](https://github.com/yeliex) in [https://github.com/swc-project/swc-node/pull/748](https://github.com/swc-project/swc-node/pull/748) - chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/747](https://github.com/swc-project/swc-node/pull/747) - feat(core): support swc's `ignoreDynamic` option by [@​SukkaW](https://github.com/SukkaW) in [https://github.com/swc-project/swc-node/pull/745](https://github.com/swc-project/swc-node/pull/745) - fix: fix import ts from node_modules by [@​yeliex](https://github.com/yeliex) in [https://github.com/swc-project/swc-node/pull/744](https://github.com/swc-project/swc-node/pull/744) - Mention --enable-source-maps in README.md for esm projects. by [@​Xinkai](https://github.com/Xinkai) in [https://github.com/swc-project/swc-node/pull/737](https://github.com/swc-project/swc-node/pull/737) - feat: upgrade dependencies by [@​Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/swc-project/swc-node/pull/751](https://github.com/swc-project/swc-node/pull/751) #### New Contributors - [@​devjiwonchoi](https://github.com/devjiwonchoi) made their first contribution in [https://github.com/swc-project/swc-node/pull/728](https://github.com/swc-project/swc-node/pull/728) - [@​cm-ayf](https://github.com/cm-ayf) made their first contribution in [https://github.com/swc-project/swc-node/pull/727](https://github.com/swc-project/swc-node/pull/727) - [@​eliellis](https://github.com/eliellis) made their first contribution in [https://github.com/swc-project/swc-node/pull/725](https://github.com/swc-project/swc-node/pull/725) - [@​dsyddall](https://github.com/dsyddall) made their first contribution in [https://github.com/swc-project/swc-node/pull/740](https://github.com/swc-project/swc-node/pull/740) - [@​SukkaW](https://github.com/SukkaW) made their first contribution in [https://github.com/swc-project/swc-node/pull/745](https://github.com/swc-project/swc-node/pull/745) - [@​Xinkai](https://github.com/Xinkai) made their first contribution in [https://github.com/swc-project/swc-node/pull/737](https://github.com/swc-project/swc-node/pull/737) **Full Changelog**: https://github.com/swc-project/swc-node/compare/[@​swc-node/core](https://github.com/swc-node/core)[@​1](https://github.com/1).10.5...[@​swc-node/register](https://github.com/swc-node/register)[@​1](https://github.com/1).8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/austinbiggs/ivy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
tsang-bot bot
referenced
this pull request
in tsangste/nx-package-test
Feb 6, 2024
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@swc-node/register](https://github.com/swc-project/swc-node) | [`1.6.8` -> `1.8.0`](https://renovatebot.com/diffs/npm/@swc-node%2fregister/1.6.8/1.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@swc/cli](https://github.com/swc-project/pkgs) ([source](https://github.com/node ./bin)) | [`0.3.5` -> `0.3.6`](https://renovatebot.com/diffs/npm/@swc%2fcli/0.3.5/0.3.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>swc-project/swc-node (@​swc-node/register)</summary> ### [`v1.8.0`](https://github.com/swc-project/swc-node/releases/tag/%40swc-node/register%401.8.0) [Compare Source](https://github.com/swc-project/swc-node/compare/@swc-node/register@1.6.8...@swc-node/register@1.8.0) #### What's Changed - fix(core): remove `jsc.module.noInterop` when it's not supported by [@​kdy1](https://github.com/kdy1) in [https://github.com/swc-project/swc-node/pull/733](https://github.com/swc-project/swc-node/pull/733) - chore: fix README for install, build, and test by [@​devjiwonchoi](https://github.com/devjiwonchoi) in [https://github.com/swc-project/swc-node/pull/728](https://github.com/swc-project/swc-node/pull/728) - feat(register): @​swc-node/register/esm use TypeScript resolver by [@​cm-ayf](https://github.com/cm-ayf) in [https://github.com/swc-project/swc-node/pull/727](https://github.com/swc-project/swc-node/pull/727) - chore(deps-dev): bump [@​babel/traverse](https://github.com/babel/traverse) from 7.22.10 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/735](https://github.com/swc-project/swc-node/pull/735) - Fix [#​716](https://github.com/swc-project/swc-node/issues/716) by [@​eliellis](https://github.com/eliellis) in [https://github.com/swc-project/swc-node/pull/725](https://github.com/swc-project/swc-node/pull/725) - chore(deps-dev): bump axios from 1.3.5 to 1.6.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/738](https://github.com/swc-project/swc-node/pull/738) - fix(core): respect useDefineForClassFields tsconfig value by [@​dsyddall](https://github.com/dsyddall) in [https://github.com/swc-project/swc-node/pull/740](https://github.com/swc-project/swc-node/pull/740) - fix(core): respect sourceMaps swcrc value by [@​dsyddall](https://github.com/dsyddall) in [https://github.com/swc-project/swc-node/pull/742](https://github.com/swc-project/swc-node/pull/742) - feat: add esm-register for node>20.6 by [@​yeliex](https://github.com/yeliex) in [https://github.com/swc-project/swc-node/pull/748](https://github.com/swc-project/swc-node/pull/748) - chore(deps-dev): bump follow-redirects from 1.15.2 to 1.15.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/swc-project/swc-node/pull/747](https://github.com/swc-project/swc-node/pull/747) - feat(core): support swc's `ignoreDynamic` option by [@​SukkaW](https://github.com/SukkaW) in [https://github.com/swc-project/swc-node/pull/745](https://github.com/swc-project/swc-node/pull/745) - fix: fix import ts from node_modules by [@​yeliex](https://github.com/yeliex) in [https://github.com/swc-project/swc-node/pull/744](https://github.com/swc-project/swc-node/pull/744) - Mention --enable-source-maps in README.md for esm projects. by [@​Xinkai](https://github.com/Xinkai) in [https://github.com/swc-project/swc-node/pull/737](https://github.com/swc-project/swc-node/pull/737) - feat: upgrade dependencies by [@​Brooooooklyn](https://github.com/Brooooooklyn) in [https://github.com/swc-project/swc-node/pull/751](https://github.com/swc-project/swc-node/pull/751) #### New Contributors - [@​devjiwonchoi](https://github.com/devjiwonchoi) made their first contribution in [https://github.com/swc-project/swc-node/pull/728](https://github.com/swc-project/swc-node/pull/728) - [@​cm-ayf](https://github.com/cm-ayf) made their first contribution in [https://github.com/swc-project/swc-node/pull/727](https://github.com/swc-project/swc-node/pull/727) - [@​eliellis](https://github.com/eliellis) made their first contribution in [https://github.com/swc-project/swc-node/pull/725](https://github.com/swc-project/swc-node/pull/725) - [@​dsyddall](https://github.com/dsyddall) made their first contribution in [https://github.com/swc-project/swc-node/pull/740](https://github.com/swc-project/swc-node/pull/740) - [@​SukkaW](https://github.com/SukkaW) made their first contribution in [https://github.com/swc-project/swc-node/pull/745](https://github.com/swc-project/swc-node/pull/745) - [@​Xinkai](https://github.com/Xinkai) made their first contribution in [https://github.com/swc-project/swc-node/pull/737](https://github.com/swc-project/swc-node/pull/737) **Full Changelog**: https://github.com/swc-project/swc-node/compare/[@​swc-node/core](https://github.com/swc-node/core)[@​1](https://github.com/1).10.5...[@​swc-node/register](https://github.com/swc-node/register)[@​1](https://github.com/1).8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3Mi4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: tsang-bot[bot] <146107447+tsang-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #739
Currently,
useDefineForClassFieldsis not read fromtsconfig.jsonand not set in the SWC config.This PR updates the
tsCompilerOptionsToSwcConfigfunction to read the value ofuseDefineForClassFieldsfromtsconfig.json(using the default value based ontargetas specified at https://www.typescriptlang.org/tsconfig#useDefineForClassFields)See: https://swc.rs/docs/configuration/compilation#jsctransformusedefineforclassfields