Strange interactions between interactive search and overlays (such as Show Files)

[tllilleh]

I you open up the Show Files overlay (ctrl+x, ctrl+f) and then start an incremental search (cntrl+s) the Show Files overlay gets stuck open. Other strange interactions can also occur if you attempt to open the Show Files overlay while in the middle of an incremental search. I've worked around these locally by modifying my keymap:

---

// Goto open file
{"keys": ["ctrl+x", "ctrl+f"], "command": "nop"},
{"keys": ["ctrl+x", "ctrl+f"], "command": "show_overlay", "args": {"overlay": "goto", "show_files": true}, "context": [{"key": "i_search_active", "operand": false}]},

---

{"keys": ["ctrl+s"], "command": "nop"},
{"keys": ["ctrl+s"], "command": "sbp_inc_search", "args": {"forward": true, "regex": false}, "context": [{"key": "overlay_visible", "operator": "equal", "operand": false}]},
{"keys": ["ctrl+r"], "command": "nop"},
{"keys": ["ctrl+r"], "command": "sbp_inc_search", "args": {"forward": false, "regex": false}, "context": [{"key": "overlay_visible", "operator": "equal", "operand": false}]},

---

It's hacky because I need to rely on a fictional "nop" command to force the key to do nothing if the condition is not met.