Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Docker support #321

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Feat: Add Docker support #321

merged 4 commits into from
Oct 17, 2022

Conversation

mako-max
Copy link
Contributor

@mako-max mako-max commented Oct 13, 2022

With this PR Howitzer will generate several files related with Docker/Compose

#317

@mako-max mako-max self-assigned this Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 98.85% // Head: 99.02% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (1fbb87b) compared to base (4d64552).
Patch coverage: 99.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   98.85%   99.02%   +0.17%     
==========================================
  Files          44       48       +4     
  Lines        1218     1339     +121     
==========================================
+ Hits         1204     1326     +122     
+ Misses         14       13       -1     
Impacted Files Coverage Δ
generators/root/root_generator.rb 100.00% <ø> (ø)
lib/howitzer/email.rb 100.00% <ø> (ø)
lib/howitzer/web/section_dsl.rb 93.44% <0.00%> (ø)
generators/base_generator.rb 100.00% <100.00%> (ø)
lib/howitzer/capybara_helpers.rb 100.00% <100.00%> (+1.07%) ⬆️
lib/howitzer/mail_adapters/mailgun.rb 100.00% <100.00%> (ø)
lib/howitzer/mail_adapters/mailtrap.rb 100.00% <100.00%> (ø)
lib/howitzer/mail_adapters/onesecmail.rb 100.00% <100.00%> (ø)
lib/howitzer/mail_adapters/testmail.rb 100.00% <100.00%> (ø)
lib/howitzer/mailtrap_api/client.rb 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romikoops romikoops changed the title Added generation of the docker related files Feat: Add Docker support Oct 13, 2022
@romikoops romikoops marked this pull request as ready for review October 13, 2022 23:41
@romikoops romikoops merged commit d0e7bc9 into master Oct 17, 2022
@romikoops romikoops deleted the dockerfiles_generator branch October 17, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants