Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UPPERCASE text-transform from labels #793

Closed
shilman opened this issue Apr 15, 2017 · 6 comments
Closed

Remove UPPERCASE text-transform from labels #793

shilman opened this issue Apr 15, 2017 · 6 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by philcockfield
Tuesday Oct 04, 2016 at 08:44 GMT
Originally opened as storybook-eol/storybook-addon-knobs#53


I understand stylistically the reason to put that transform on the property label, BUT with camelCase there is information contained with the name (the word-parts) that you are stomping out by applying this style. It's valid and helpful information for the developer working with the knobs:

image

It would be great if you reset this to display as the actual name of the property! Digging knobs, nice work!

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by arunoda
Tuesday Oct 04, 2016 at 09:47 GMT


I get the point. Happy to accept to a PR :)

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by philcockfield
Tuesday Oct 04, 2016 at 19:07 GMT


Ha ha! "Happy to accept to a PR :)" should be a keyboard shortcut. I'll take a look.

Also, want to talk about the index selector on StoryBook itself. Is that a pluggable module - there's some improvements I'd like to make to it. What's the feasibility of that?

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by arunoda
Tuesday Oct 04, 2016 at 23:10 GMT


What's index selector?
If that's something new, let's discuss in a new issue.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by philcockfield
Thursday Oct 06, 2016 at 18:45 GMT


Hey @arunoda - I was referring to this when I said "index selector":

image

But that's not knobs, or even this issue, so I'll start a new issue on the storybook repo.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by arunoda
Thursday Oct 06, 2016 at 22:42 GMT


Yep. It's on the Storybook UI repo.
That's not pluggable yet.
But we want to customize it (To show stories only for changed snapshots).
Currently, there no plans on how we should do it.

@mthuret
Copy link
Member

mthuret commented Apr 18, 2017

A PR fixing this was merged couple days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants