Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override provided devtool #666

Closed
pelotom opened this issue Jan 11, 2017 · 1 comment
Closed

Do not override provided devtool #666

pelotom opened this issue Jan 11, 2017 · 1 comment
Labels
feature request

Comments

@pelotom
Copy link
Contributor

pelotom commented Jan 11, 2017 •
edited
Loading

It looks like Storybook overrides whatever devtool I specify in my webpack.config.js with "eval". Unfortunately this breaks line numbers in stack traces when using transpiled languages (in my case TypeScript). Providing a default devtool seems fine, but if my config specifies a devtool it shouldn't get overridden by storybook.
@arunoda
Copy link
Member

arunoda commented Jan 12, 2017

Yeah! We should do that.
This is the place we need to update: https://github.com/storybooks/react-storybook/blob/master/src/server/config.js#L87

I am happy to take a PR for this.

@pelotom pelotom mentioned this issue Jan 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arunoda @pelotom