-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cycle detection doesn't catch cycles through collections #652
Comments
To be fixed |
I have a fix for this (plus a unit test), as well as a couple other locations this might still be happening. I'll try to make a PR tomorrow. Can you assign me please? Thank you. |
I don't think it will be possible to check for cycles in collections without impacting performance. If you disagree, post here to reopen this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The cycle detection introduced in #632 / #645 doesn't handle cycles that involved collections. The following example still results in a
StackOverflowError
:The text was updated successfully, but these errors were encountered: