Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Spree::Role be a tenanted model? #12

Open
eLafo opened this issue Apr 4, 2014 · 1 comment
Open

Should Spree::Role be a tenanted model? #12

eLafo opened this issue Apr 4, 2014 · 1 comment

Comments

@eLafo
Copy link

eLafo commented Apr 4, 2014

I think that I am missing something because I do not get which the point is for Spree::Role to be a tenanted model

If I create a new Tenant, authorization will fail, since I need to create new roles for it. Maybe I am missing something, but I think that roles should be the same for all the tenants unless they are customizable by tenant, which they are not, right now, aren't they?

@fattymiller
Copy link

I like the idea of separating the roles based on shops as this will allow different shops to have their own roles without needing to jump through hoops to fit in to a previously defined model.

New shop setups can be a pain, but this can be easily corrected by creating a default set of Roles upon Shop creation, and then allow the shop owner to make changes at their leisure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants