Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Adding Performer from Scene Tagger Fails #4437

Closed
bdbenim opened this issue Jan 8, 2024 · 1 comment · Fixed by #4443
Closed

[Bug Report] Adding Performer from Scene Tagger Fails #4437

bdbenim opened this issue Jan 8, 2024 · 1 comment · Fixed by #4443
Labels
bug Something isn't working

Comments

@bdbenim
Copy link
Contributor

bdbenim commented Jan 8, 2024

Describe the bug
When scraping a scene from stash-box in the scene tagger view, the user is prompted to add missing performers with their data pre-filled from stash-box. If a performer being added has an alias matching their primary name, adding them to the user's stash instance will fail.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the scene tagger view and select a stash-box instance as the source
  2. Choose a scene which exists in stash-box and for which not all performers are in the local database (if necessary, delete a performer or their Stash ID for testing)
  3. Click on 'Scrape by fragment'
  4. For the missing performer, click 'Create' and then 'Save'
  5. If the performer has an alias matching their primary name, an error message will be displayed

Expected behavior
The duplicate alias should be ignored and the performer added as normal. Alternatively, details should be editable in the "Create Performer" modal, which would allow the user to manually delete the bad data.

Screenshots
image

Stash Version: (from Settings -> About):

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 0.24.1
@bdbenim bdbenim added the bug report Bug reports that are not yet verified label Jan 8, 2024
@WithoutPants WithoutPants added bug Something isn't working and removed bug report Bug reports that are not yet verified labels Jan 9, 2024
@Maista6969
Copy link
Sponsor Contributor

Just had a related issue pop up with performers who have duplicate aliases on StashDB

StashDB considers different casings of the same name to be unique aliases, see for example Syren De Mer who has both "Syren DeMer" and "Syren Demer". Should Stash follow this pattern as well, or should we deduplicate these aliases when adding new performers? If so, which one to pick? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants