Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan fails on symlinked zip file: not a valid zip file #4086

Closed
evandeaubl opened this issue Sep 5, 2023 · 3 comments · Fixed by #5249
Closed

Scan fails on symlinked zip file: not a valid zip file #4086

evandeaubl opened this issue Sep 5, 2023 · 3 comments · Fixed by #5249
Labels
bug Something isn't working

Comments

@evandeaubl
Copy link

Describe the bug
When I symlink a zip file into one of my Stash library directories and do a scan, it is not integrated into the library as a gallery. When you look at the logs, you see a "not a valid zip file" error logged.

Copying the same zip file into the Stash library at the same location and scanning works correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Symlink a zip file into one of the active library directories enabled for images
  2. Go to Setttings->Tasks, and select Scan
  3. Go to Settings->Logs, and observe that zip file scan resulted in "not a valid zip file" error
Error scanning zip file "XXXXX.zip": zip: not a valid zip file

Expected behavior
Zip file integrated into Stash library as gallery

Stash Version: (from Settings -> About): 0.22.1

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Safari
  • Version: 17.0
@evandeaubl evandeaubl added the bug report Bug reports that are not yet verified label Sep 5, 2023
@peresabcod
Copy link

As far as I know, symlinks are just a link to another location, if that location it's outside your library folders, I don't think stash will be able to index it. You probably should use a hard link instead, wich is more like a mirror.

@WithoutPants WithoutPants modified the milestone: Version 0.25.0 Feb 13, 2024
@laurus-lx
Copy link

Same problem on Debian with zip files in symlinks not working with Stash (get error message - not valid zip file while scanning, same file work well when not symlinkes).

Current tested/working hack to resolve this - mount directory with Samba set to resolve symlinks.

Proper fix will be much appreciated!

@WithoutPants
Copy link
Collaborator

I've managed to reproduce this. It's a bit of an involved fix, so I likely won't fit it into a 0.26.x bugfix.

@WithoutPants WithoutPants added bug Something isn't working and removed bug report Bug reports that are not yet verified labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants