This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Popup): Set aria-modal for both Dialog and Popup with focus trap #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 81.08% 81.08% +<.01%
==========================================
Files 671 671
Lines 8621 8625 +4
Branches 1520 1520
==========================================
+ Hits 6990 6994 +4
Misses 1616 1616
Partials 15 15
Continue to review full report at Codecov.
|
packages/react/src/lib/accessibility/Behaviors/Popup/popupFocusTrapBehavior.ts
Show resolved
Hide resolved
…sTrapBehavior.ts Co-Authored-By: sophieH29 <8460706+sophieH29@users.noreply.github.com>
layershifter
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
DialogandPopupwith focus trap behavior, should have setaria-modal=true