This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(RTL): apply static styles using the top-most Fela renderer #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 80.72% 80.73% +0.01%
==========================================
Files 659 659
Lines 8457 8462 +5
Branches 1429 1495 +66
==========================================
+ Hits 6827 6832 +5
Misses 1616 1616
Partials 14 14
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 81.1% 81.11% +0.01%
==========================================
Files 671 671
Lines 8612 8617 +5
Branches 1514 1452 -62
==========================================
+ Hits 6985 6990 +5
Misses 1612 1612
Partials 15 15
Continue to review full report at Codecov.
|
bmdalex
approved these changes
Feb 26, 2019
layershifter
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static styles were always applied on LTR Fela renderer, fixes #948.
Now the first (top level)
Providerdecides which renderer to use, caches it, and all other Providers reuse that renderer to apply static styles.