Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Dropdown|Input): call callback on clear #956

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Conversation

layershifter
Copy link
Member

Fixes #930.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #956 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage    80.5%   80.72%   +0.21%     
==========================================
  Files         659      659              
  Lines        8450     8457       +7     
  Branches     1493     1493              
==========================================
+ Hits         6803     6827      +24     
+ Misses       1632     1616      -16     
+ Partials       15       14       -1
Impacted Files Coverage Δ
packages/react/src/components/Input/Input.tsx 100% <100%> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 39.68% <100%> (+5.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72eab06...60d635e. Read the comment docs.

Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No UT added?

@layershifter layershifter merged commit 600115a into master Feb 25, 2019
@layershifter layershifter deleted the fix/input-clear branch February 25, 2019 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants