Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Text): apply display: inline-block only if the animation prop is provided while the Text is rendered as span #940

Merged
merged 5 commits into from
Feb 26, 2019

Conversation

mnajdova
Copy link
Contributor

There was bug with the Text component in Teams theme. Basically the component was created with as='div', but it wasn't converted to block element, because the display prop was always applied as 'inline-block'.

Example:

  <>
    <Text important as='div' content="This text is important!" />
    <Text content='Some other content' />
  </>

Previosly:
image

Now:
image

Animations are still working with the as property being span or div

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #940 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   80.78%   80.74%   -0.04%     
==========================================
  Files         665      665              
  Lines        8504     8508       +4     
  Branches     1433     1435       +2     
==========================================
  Hits         6870     6870              
- Misses       1620     1624       +4     
  Partials       14       14
Impacted Files Coverage Δ
...eact/src/themes/base/components/Text/textStyles.ts 4.65% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109d501...7b4bdc4. Read the comment docs.

@mnajdova mnajdova merged commit 4d697e0 into master Feb 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/text-inline-block branch February 26, 2019 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants