This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Icon): bordered and circular props not working as expected #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 649 649
Lines 8319 8319
Branches 1420 1420
=======================================
Hits 6704 6704
Misses 1600 1600
Partials 15 15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 80.51% 80.51%
=======================================
Files 659 659
Lines 8447 8447
Branches 1492 1492
=======================================
Hits 6801 6801
Misses 1631 1631
Partials 15 15
Continue to review full report at Codecov.
|
docs/src/examples/components/Icon/Variations/IconExampleCircular.shorthand.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
approved these changes
Feb 20, 2019
added 2 commits
February 20, 2019 17:00
# Conflicts: # CHANGELOG.md
layershifter
approved these changes
Feb 20, 2019
added 6 commits
February 20, 2019 17:08
-fixes examples and components dependent on the circular Icon
bmdalex
approved these changes
Feb 21, 2019
delete-merged-branch
bot
deleted the
fix/icon-circular-without-border
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #635 The problem was that when the
circularprop was provided to the Icon comoponent, there were always borders added as well. This logic is eliminated in this PR.BREAKING CHANGES
Using only the
circularprop on theIconwill no longer add theborderby default. If you want to persist theborder, you should add theborderedprop on the component as well.For fixing regressions on the Icons that contain the
circularprop, add theborderedprop as well. For example:<Icon name='umbrella' circular /> <=> <Icon name='umbrella' circular bordered />