This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Avatar): display correctly images in portrait mode #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 80.59% 80.59%
=======================================
Files 649 649
Lines 8321 8321
Branches 1484 1420 -64
=======================================
Hits 6706 6706
Misses 1600 1600
Partials 15 15
Continue to review full report at Codecov.
|
mnajdova
reviewed
Feb 18, 2019
CHANGELOG.md
Outdated
| @@ -29,6 +29,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Keyframes are behaving as expected when RTL is dynamically switched @layershifter ([#894](https://github.com/stardust-ui/react/pull/894)) | |||
| - Fix inserting char at a cursor position will the cursor to end in `Dropdown` @layershifter ([#897](https://github.com/stardust-ui/react/pull/897)) | |||
| - Replace margins with padding in `chatItemStyles` for Teams theme ([#878](https://github.com/stardust-ui/react/pull/878)) | |||
| - Display correctly images in portrait mode inside `Avatar` @layershifter ([#899](https://github.com/stardust-ui/react/pull/899)) | |||
There was a problem hiding this comment.
Be sure that this will be in the correct section after merging the master (we released 0.21.1)
mnajdova
approved these changes
Feb 18, 2019
|
Also works with extra small images: <>
<Avatar image="public/images/avatar/small/matt.jpg" />
<Avatar image="public/images/avatar/large/jerry.png" />
<Avatar image="https://via.placeholder.com/16x16" />
</> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes display images inside
Avatarthat are in portrait mode.Before
After