This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): Do not stop propagation when pressing Esc on trigger element #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported:
Fix:
There shouldn't be
e.stopPropagation
forclose
action inPopup
component.e.stopPropagation
was added initially forcloseAndFocusTrigger
actions based on reasons described in this PR #515, but it wasn't needed when pressingEsc
just on trigger button, what was added here #622