This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Menu): Adding dark & contrast themes for Menu toolbar #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
28 tasks
added 9 commits
January 11, 2019 12:35
codepretty
changed the title
codepretty
changed the title
codepretty
commented
Jan 12, 2019
| <svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}> | ||
| <g> | ||
| <path | ||
| className={cx('ui-icon__outline', classes.outlinePart)} |
There was a problem hiding this comment.
@miroslavstastny I'm using the poc you did in #364. i manually added this to a couple icons for this toolbar, but we will need to get this added to all icons. are you planning on doing this?
miroslavstastny
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes themeing for the toolbar variation of the Menu component.
Fixes include:
Teams theme
Teams-dark theme
Teams-high-contrast theme
