This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Menu): correctly handle disabled item #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
kolaps33
approved these changes
Jan 10, 2019
bmdalex
approved these changes
Jan 14, 2019
sophieH29
reviewed
Jan 15, 2019
sophieH29
approved these changes
Jan 15, 2019
| @@ -35,7 +36,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Add `MenuDivider` component and `kind` prop to the `items` inside of the `Menu` for creating different components @mnajdova ([#682](https://github.com/stardust-ui/react/pull/682)) | |||
|
|
|||
| ### Fixes | |||
| - Fix unicode arrow characters to be RTL aware ([#690](https://github.com/stardust-ui/react/pull/690)) | |||
| - Fix unicode arrow characters to be RTL aware @mnajdova ([#690](https://github.com/stardust-ui/react/pull/690)) | |||
docs/src/examples/components/Menu/States/MenuExampleDisabled.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Jan 15, 2019
kuzhelov
reviewed
Jan 15, 2019
kuzhelov
reviewed
Jan 15, 2019
kuzhelov
reviewed
Jan 15, 2019
kuzhelov
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds correct styles and fixes behaviors for disabled menu item. Fixes #186.
MenuItem-test.tsxwith @kolaps33 / @jurokapsiar - why is behavior-test not enough?MenuItem-test.tsx, accessibility integration smoke test added there.IS_FOCUSABLE_ATTRIBUTE(check it is set only if notdisabled)aria-disabledis handled - instead of addingaria-disabled=falsethe attribute is omitted.