This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(segment): color prop #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
9 tasks
docs/src/examples/components/Segment/Variations/SegmentExampleColor.shorthand.tsx
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
feat/segment-color-prop
branch
2 times, most recently
from
420d71f
to
e1448bd
Compare
bmdalex
force-pushed
the
feat/segment-color-prop
branch
from
e1448bd
to
8be8c3a
Compare
bmdalex
force-pushed
the
feat/segment-color-prop
branch
from
8be8c3a
to
c561c69
Compare
kuzhelov
reviewed
Dec 20, 2018
bmdalex
force-pushed
the
feat/segment-color-prop
branch
2 times, most recently
from
7466bb9
to
0048e09
Compare
kuzhelov
approved these changes
Dec 20, 2018
bmdalex
added
ready for merge
and removed
needs author feedback
miroslavstastny
approved these changes
Dec 20, 2018
bmdalex
force-pushed
the
feat/segment-color-prop
branch
from
0048e09
to
b565213
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(segment): color prop
Description
This PR:
colorprop toSegmentcomponentSegmentcolor examplesAPI
where
COLORis one of'primary' | 'secondary' | 'blue' | 'green' | 'grey' | 'orange' | 'pink' | 'purple' | 'teal' | 'red' | 'yellow' | stringKnown issues:
Segment text color should be dark shade of gray on segments with light background color, tracked by #629