This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icons): Added icon for add-page and also added missing icon sizes #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
priyankar205
commented
Dec 12, 2018
priyankar205
commented
- Added add-page icon
- Added sizes 'x-large' and 'xx-large' for icons.
priyankar205
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
reviewed
Dec 12, 2018
kuzhelov
reviewed
Dec 12, 2018
kuzhelov
reviewed
Dec 12, 2018
kuzhelov
reviewed
Dec 12, 2018
kuzhelov
reviewed
Dec 12, 2018
| @@ -18,4 +18,5 @@ export default { | |||
| </svg> | |||
| ), | |||
| styles: {}, | |||
| exportedAs: 'canvas-add-page', | |||
kuzhelov
reviewed
Dec 12, 2018
| @@ -50,6 +51,7 @@ export default { | |||
| 'call-control-present-new': callControlPresentNew, | |||
| 'call-control-stop-presenting-new': callControlStopPresentingNew, | |||
| 'call-recording': callRecording, | |||
| 'canvas-add-page': canvasAddPage, | |||
kuzhelov
approved these changes
Dec 12, 2018
kuzhelov
added
ready for merge
and removed
needs author feedback
codepretty
reviewed
Dec 12, 2018
| if (!sizeModifier) { | ||
| return sizes.get(size) | ||
| } | ||
| const modifiedSizes = { |
There was a problem hiding this comment.
What is the context this icon will be used? We will need a way to specify sizing, but I don't believe we want to do it in css. In Teams, the different sizes should actually be different icons (in most cases).
|
We need to undo the complexity added here with the We should instead unify our 3 sizing patterns to accomplish this feature. Let's always reduce complexity with changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.