Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Image): 'fluid' variant and size variables #54

Merged
merged 5 commits into from
Aug 7, 2018

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Aug 7, 2018

Image

The necessary functionality for customizing size of Image component has been introduced.

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

Fluid

image

Make parent's width to be a width of the Image component.

<Image fluid />

'width' and 'height' variables

These could be used to precisely set width and height of the Image.

{ /* height is set to 'auto' by default */ }
<Image variables={{ width: '100px' }} />

<Image variables={{ width: '100px', height: '100px' }} />

@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #54 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   87.39%   87.36%   -0.03%     
==========================================
  Files          74       74              
  Lines        1150     1148       -2     
  Branches      215      207       -8     
==========================================
- Hits         1005     1003       -2     
  Misses        141      141              
  Partials        4        4
Impacted Files Coverage Δ
src/components/Image/Image.tsx 100% <100%> (ø) ⬆️
src/components/Image/imageRules.tsx 100% <100%> (ø) ⬆️
src/components/Image/imageVariables.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c0891...ed44f09. Read the comment docs.

@kuzhelov kuzhelov merged commit 3172970 into master Aug 7, 2018
@kuzhelov kuzhelov deleted the feat/image-resize-and-fill branch August 8, 2018 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants